Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to inspect gateway fork logic (Labels and Conditions of Outgoing Sequence Flows) in a single place #4043

Open
till-stadtler opened this issue Dec 27, 2023 · 6 comments
Labels
backlog Queued in backlog channel:support developer productivity Everything related to improving the developer productivity (both efficiency and effectiveness) enhancement New feature or request ux

Comments

@till-stadtler
Copy link

till-stadtler commented Dec 27, 2023

Problem you would like to solve

XOR/OR gateways have multiple outgoing sequence flows. As a user I want to understand if (conditional) outgoing flows of such a forking gateway are complete, or if cases are missing.

Proposed solution

It is impossible to inspect the conditions on these sequence flows in one view, i.e. the gateways properties panel.

I would like to see all sequence flow labels and conditions in the properties panel of the OR/XOR gateway.
It would be great to have the following information in one concise view:

  • label of the gateway (question)
  • the outgoing sequence flows' details:
    • label of the sequence flow (answer)
    • condition of the sequence flow (or that it is the default sequence flow)

Alternatives considered

I like the idea of managing the gateway logic in a single place. It would be possible to make the labels and conditions in the gateway property panel editable. If the labels and conditions on the individual sequence flows are not disabled, the same details would be editable in two different property panels.

Another option would be to only have one property panel which is shared across the gateway and sequence flows. Thus, when clicking on an outgoing sequence flow, the shared property panel will open up instead. Outgoing sequence flows would not have a property panel on their own.

Additional context

This concise view makes it easier to understand if a gateway is complete, meaning that no incident will be thrown given that all involved process variables exist.
For incomplete gateways, the following can happen:

  • OR gateway: no condition evaluates to true and no default flow is configured
  • XOR gateway: no condition evaluates to true and no default flow is configured, or multiple conditions evaluate to true

I will create another feature request on helping to identify incomplete gateways.


Related to #369


Requested in SUPPORT-21481

@till-stadtler till-stadtler added the enhancement New feature or request label Dec 27, 2023
@ingorichtsmeier
Copy link

Like here?

Bildschirmfoto 2023-12-27 um 11 43 45

Picture using the Tooltip plugin: https://github.com/viadee/camunda-modeler-tooltip-plugin

@till-stadtler
Copy link
Author

till-stadtler commented Dec 27, 2023

Hi @ingorichtsmeier,
That would indeed solve the described problem, thank you!

A tooltip would not go well with the idea of having all the info editable/having one shared property panel. Any thoughts on that?

@nikku nikku changed the title Add Concise View of Gateway Logic (Labels and Conditions of Outgoing Sequence Flows) to the Gateway's Property Panel Be able to see gateway for logic (Labels and Conditions of Outgoing Sequence Flows) in a single place Jan 2, 2024
@nikku nikku changed the title Be able to see gateway for logic (Labels and Conditions of Outgoing Sequence Flows) in a single place Add ability to inspect gateway fork logic (Labels and Conditions of Outgoing Sequence Flows) in a single place Jan 2, 2024
@nikku
Copy link
Member

nikku commented Jan 2, 2024

@till-stadtler From what I understand you want to be able to assess if conditions behind a forking gateway are "complete" or generally "what conditions are configured". You seek tooling support to do that. Is that correct? In this sense I'm not sure if #4044 are duplicates?

One solution that @ingorichtsmeier highlighted is a simple overlay on the diagram (#4043 (comment)). We could expand this / incorporate it into the core tooling, i.e. show crucial "meta information" as you hover a node on the diagram:

image

What on canvas annotations bring to the table is that they are better at conveying the additional (diagram) context. #369 is related.

Does it really matter to you if the information is available on the properties panel, or the canvas?

@nikku
Copy link
Member

nikku commented Jan 2, 2024

I updated the issue description with regards to my assessment, please double-check @till-stadtler.

@nikku nikku added needs more information Requires additional information to be actionable. ux developer productivity Everything related to improving the developer productivity (both efficiency and effectiveness) backlog Queued in backlog and removed needs more information Requires additional information to be actionable. labels Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog channel:support developer productivity Everything related to improving the developer productivity (both efficiency and effectiveness) enhancement New feature or request ux
Projects
None yet
Development

No branches or pull requests

4 participants