New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong 'Edit' menu on direct editing activation #708

Closed
philippfromme opened this Issue Dec 5, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@philippfromme
Contributor

philippfromme commented Dec 5, 2017

Activating direct editing causes all instantiated editors to update the window menu due to the fact that they all globally listen to 'input:focus' events. The order in which they update the menu is not deterministic and so it happens that after activating direct editing in a DRD modeler the BPMN modeler is the last one to update the edit menu resulting in wrong menu entries.

@philippfromme philippfromme added the bug label Dec 5, 2017

@nikku

This comment has been minimized.

Member

nikku commented Mar 19, 2018

Who globally listens to this? Only one editor should be active at a time, listening to anything.

@nikku nikku added the ready label Apr 23, 2018

@nikku nikku modified the milestones: M21, M22 Apr 23, 2018

@philippfromme philippfromme added in progress and removed ready labels May 9, 2018

philippfromme added a commit that referenced this issue May 9, 2018

@philippfromme

This comment has been minimized.

Contributor

philippfromme commented May 9, 2018

@wafflebot wafflebot bot removed the in progress label May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment