New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DMN properties panel #847

Closed
philippfromme opened this Issue Jul 13, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@philippfromme
Contributor

philippfromme commented Jul 13, 2018

In order to be able to edit more technical properties of decisions a properties panel will be added.

  • properties panel will be visible independently from current editor (DRD, decision table, ...)
  • in DRD editor properties panel will display properties of currently selected element or definitions if no element is selected
  • in decision table view properties panel will always display propterties of currently opened decision

Tasks

  • remove Camunda extension from dmn-moddle bpmn-io/dmn-moddle#1
  • create camunda-dmn-moddle #849
  • create dmn-js-properties-panel
  • release dmn-js-properties-panel as npm module
  • integrate properties panel into Camunda Modeler
  • test integration into Camunda Modeler

Related to bpmn-io/dmn-js#364.
Depends on bpmn-io/dmn-js-properties-panel#1.

@philippfromme philippfromme self-assigned this Jul 13, 2018

@philippfromme philippfromme added the ready label Jul 13, 2018

philippfromme added a commit to bpmn-io/dmn-moddle that referenced this issue Jul 18, 2018

@nikku nikku added this to the M24 milestone Jul 19, 2018

philippfromme added a commit that referenced this issue Jul 26, 2018

@wafflebot wafflebot bot added in progress and removed ready labels Jul 26, 2018

@wafflebot wafflebot bot removed the in progress label Jul 27, 2018

@philippfromme philippfromme reopened this Jul 27, 2018

@philippfromme philippfromme assigned nikku and unassigned philippfromme Jul 27, 2018

@philippfromme philippfromme assigned philippfromme and unassigned nikku Jul 27, 2018

philippfromme added a commit that referenced this issue Jul 30, 2018

@philippfromme philippfromme assigned nikku and unassigned philippfromme Jul 30, 2018

@nikku

This comment has been minimized.

Show comment
Hide comment
@nikku

nikku Jul 30, 2018

Member

I tested it and it works.

Personally I don't like the fact that we waste a lot of space on the Table and Literal Expression views through:

image

Why can't we let the properties panel overlap and wait for feedback?

Member

nikku commented Jul 30, 2018

I tested it and it works.

Personally I don't like the fact that we waste a lot of space on the Table and Literal Expression views through:

image

Why can't we let the properties panel overlap and wait for feedback?

@nikku

This comment has been minimized.

Show comment
Hide comment
@nikku

nikku Jul 30, 2018

Member

Making the space unusable is contra-productive if we discuss issues like this one one in parallel, too.

Member

nikku commented Jul 30, 2018

Making the space unusable is contra-productive if we discuss issues like this one one in parallel, too.

@nikku

This comment has been minimized.

Show comment
Hide comment
@nikku

nikku Jul 30, 2018

Member

My suggestion would be:

  • Add a general properties panel toggle shortcut, available for all editors
  • Allow properties panel to be toggled via menu for all editors
  • Hide toggle in collapsed state on literal expression and decision table editor and wait for feedback that tells us to show it.
Member

nikku commented Jul 30, 2018

My suggestion would be:

  • Add a general properties panel toggle shortcut, available for all editors
  • Allow properties panel to be toggled via menu for all editors
  • Hide toggle in collapsed state on literal expression and decision table editor and wait for feedback that tells us to show it.
@philippfromme

This comment has been minimized.

Show comment
Hide comment
@philippfromme

philippfromme Jul 30, 2018

Contributor

Sure, why not.

Contributor

philippfromme commented Jul 30, 2018

Sure, why not.

nikku added a commit that referenced this issue Jul 31, 2018

nikku added a commit that referenced this issue Jul 31, 2018

@nikku

This comment has been minimized.

Show comment
Hide comment
@nikku

nikku Jul 31, 2018

Member

Added general properties panel toggle via #863.

Member

nikku commented Jul 31, 2018

Added general properties panel toggle via #863.

@nikku

This comment has been minimized.

Show comment
Hide comment
@nikku

nikku Jul 31, 2018

Member

Show properties toggle in closed state in DRD only via 7c23d27.

Member

nikku commented Jul 31, 2018

Show properties toggle in closed state in DRD only via 7c23d27.

nikku added a commit that referenced this issue Jul 31, 2018

nikku added a commit that referenced this issue Jul 31, 2018

nikku added a commit that referenced this issue Jul 31, 2018

philippfromme added a commit that referenced this issue Jul 31, 2018

philippfromme added a commit that referenced this issue Jul 31, 2018

@wafflebot wafflebot bot removed the needs review label Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment