New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts still enabled while deployment modal is open #929

Closed
mschoe opened this Issue Sep 27, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@mschoe
Copy link
Member

mschoe commented Sep 27, 2018

Describe the Bug

The keyboard shortcuts are still enabled while the deployment modal view is open (deploy current diagram and configure deployment endpoint). I'm always frustrated when I enter a name for my deployment that contains an e, because it activates the label edit feature in the background!

Steps to Reproduce

  1. create a new bpmn diagram
  2. select an element in the diagram
  3. open the 'Deploy Current Diagram' menu
  4. enter e as name for the deployment
  5. look at the selected element in the background

Problem

The focus has switched to the element label

Expected Behavior

While a modal view is open operations in the background are not possible.

Environment

  • Camunda Modeler Version: [2.0.1] Linux and Windows

@mschoe mschoe added the bug label Sep 27, 2018

@nikku nikku added ready and removed backlog labels Nov 19, 2018

@nikku nikku added this to the M26 milestone Nov 23, 2018

@philippfromme philippfromme referenced this issue Nov 27, 2018

Closed

Make deploy toolbar action work #906

6 of 6 tasks complete

barmac added a commit that referenced this issue Nov 28, 2018

fix(deploy-toolbar): disable shortcuts when modal is active
* Editor keyboard shortcuts are no longer active when modal is open.
* Modal can now use `onMenuUpdate` prop to provide customized menu.
* BPMN and DMN editors no longer keep XML in component state as
  it was used only for the tests. It is still provided as a prop
  and kept in modeler instance, though.

Closes #929.

@wafflebot wafflebot bot added needs review and removed ready labels Nov 29, 2018

barmac added a commit that referenced this issue Dec 3, 2018

fix(deploy-toolbar): disable shortcuts when modal is active
* Editor keyboard shortcuts are no longer active when modal is open.
* Modal can now use `onMenuUpdate` prop to provide customized menu.
* BPMN and DMN editors no longer keep XML in component state as
  it was used only for the tests. It is still provided as a prop
  and kept in modeler instance, though.

Closes #929.

barmac added a commit that referenced this issue Dec 3, 2018

feat(deploy-toolbar): disable shortcuts when modal is active
* Editor keyboard shortcuts are no longer active when modal is open.
* Modal can now use `onMenuUpdate` prop to provide customized menu.
* BPMN and DMN editors no longer keep XML in component state as
  it was used only for the tests. It is still provided as a prop
  and kept in modeler instance, though.

Closes #929.

barmac added a commit that referenced this issue Dec 3, 2018

feat(deploy-toolbar): use custom menu
* Editor keyboard shortcuts are no longer active when modal is open.
* Modal can now use `onMenuUpdate` prop to provide customized menu.
* BPMN and DMN editors no longer keep XML in component state as
  it was used only for the tests. It is still provided as a prop
  and kept in modeler instance, though.

Closes #929.

barmac added a commit that referenced this issue Dec 3, 2018

feat(deploy-toolbar): use custom menu
* Editor keyboard shortcuts are no longer active when modal is open.
* Modal can now use `onMenuUpdate` prop to provide customized menu.
* BPMN and DMN editors no longer keep XML in component state as
  it was used only for the tests. It is still provided as a prop
  and kept in modeler instance, though.

Closes #929.

barmac added a commit that referenced this issue Dec 3, 2018

feat(deploy-toolbar): use custom menu
* Editor keyboard shortcuts are no longer active when modal is open.
* Modal can now use `onMenuUpdate` prop to provide customized menu.
* BPMN and DMN editors no longer keep XML in component state as
  it was used only for the tests. It is still provided as a prop
  and kept in modeler instance, though.

Closes #929.
@nikku

This comment has been minimized.

Copy link
Member

nikku commented Dec 10, 2018

This is waiting for a second round of implementation, now as #1027 is addressed.

@nikku nikku added ready and removed needs review labels Dec 10, 2018

@philippfromme philippfromme referenced this issue Dec 11, 2018

Closed

Build Camunda Modeler @next (3.0.0-0) #866

58 of 58 tasks complete

@wafflebot wafflebot bot added in progress and removed ready labels Dec 13, 2018

barmac added a commit that referenced this issue Dec 18, 2018

fix(deploy-toolbar): provide edit menu for deploy toolbar
Modals can now provide own menu. For the deploy toolbar,
edit menu will use native handlers, but only if input or textarea
field is focused.

Closes #929

@wafflebot wafflebot bot added needs review and removed in progress labels Dec 18, 2018

barmac added a commit that referenced this issue Dec 18, 2018

fix(deploy-toolbar): provide edit menu for deploy toolbar
Modals can now provide own menu. For the deploy toolbar,
edit menu will use native handlers, but only if input or textarea
field is focused.

Closes #929

pinussilvestrus added a commit that referenced this issue Dec 19, 2018

fix(deploy-toolbar): provide edit menu for deploy toolbar
Modals can now provide own menu. For the deploy toolbar,
edit menu will use native handlers, but only if input or textarea
field is focused.

Closes #929

@wafflebot wafflebot bot removed the needs review label Dec 19, 2018

barmac added a commit that referenced this issue Jan 17, 2019

fix(deploy-toolbar): provide edit menu for deploy toolbar
Modals can now provide own menu. For the deploy toolbar,
edit menu will use native handlers, but only if input or textarea
field is focused.

Closes #929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment