From fc3fae3d9c2e169438784a2315f9c592a6e78ef0 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue, 30 Apr 2024 14:15:43 +0200 Subject: [PATCH] feat(jdbc): Fix descriptions following QA (#2353) (#2355) * feat(jdbc): Fix descriptions following QA --- .../hybrid/jdbc-outbound-connector-hybrid.json | 7 +++---- .../jdbc/element-templates/jdbc-outbound-connector.json | 7 +++---- .../connector/jdbc/model/request/JdbcRequestData.java | 4 ++-- .../jdbc/model/request/connection/UriConnection.java | 3 +-- 4 files changed, 9 insertions(+), 12 deletions(-) diff --git a/connectors/jdbc/element-templates/hybrid/jdbc-outbound-connector-hybrid.json b/connectors/jdbc/element-templates/hybrid/jdbc-outbound-connector-hybrid.json index 54966d50fd..a63a84c2d8 100644 --- a/connectors/jdbc/element-templates/hybrid/jdbc-outbound-connector-hybrid.json +++ b/connectors/jdbc/element-templates/hybrid/jdbc-outbound-connector-hybrid.json @@ -87,9 +87,8 @@ }, { "id" : "connection.uri", "label" : "URI", - "description" : "URI should contain JDBC driver, username, password, host name, and port number. See the documentation.)", + "description" : "URI should contain JDBC driver, username, password, host name, and port number. For more information, see the documentation.)", "optional" : false, - "value" : "jdbc:postgresql://localhost:5432/mydb", "constraints" : { "notEmpty" : true, "pattern" : { @@ -243,8 +242,8 @@ "type" : "Boolean" }, { "id" : "data.query", - "label" : "Insert the SQL Query to execute", - "description" : "The SQL query to execute. You can use named, positional or binding parameters", + "label" : "SQL Query to execute", + "description" : "You can use named, positional or binding parameters", "optional" : false, "constraints" : { "notEmpty" : true diff --git a/connectors/jdbc/element-templates/jdbc-outbound-connector.json b/connectors/jdbc/element-templates/jdbc-outbound-connector.json index 96584aeb2c..8d866a647f 100644 --- a/connectors/jdbc/element-templates/jdbc-outbound-connector.json +++ b/connectors/jdbc/element-templates/jdbc-outbound-connector.json @@ -82,9 +82,8 @@ }, { "id" : "connection.uri", "label" : "URI", - "description" : "URI should contain JDBC driver, username, password, host name, and port number. See the documentation.)", + "description" : "URI should contain JDBC driver, username, password, host name, and port number. For more information, see the documentation.)", "optional" : false, - "value" : "jdbc:postgresql://localhost:5432/mydb", "constraints" : { "notEmpty" : true, "pattern" : { @@ -238,8 +237,8 @@ "type" : "Boolean" }, { "id" : "data.query", - "label" : "Insert the SQL Query to execute", - "description" : "The SQL query to execute. You can use named, positional or binding parameters", + "label" : "SQL Query to execute", + "description" : "You can use named, positional or binding parameters", "optional" : false, "constraints" : { "notEmpty" : true diff --git a/connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/request/JdbcRequestData.java b/connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/request/JdbcRequestData.java index ee4f19943f..785c64735a 100644 --- a/connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/request/JdbcRequestData.java +++ b/connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/request/JdbcRequestData.java @@ -26,11 +26,11 @@ public record JdbcRequestData( @NotBlank @TemplateProperty( id = "query", - label = "Insert the SQL Query to execute", + label = "SQL Query to execute", group = "query", constraints = @TemplateProperty.PropertyConstraints(notEmpty = true), description = - "The SQL query to execute. You can use named, positional or binding parameters") + "You can use named, positional or binding parameters") String query, @TemplateProperty( id = "variables", diff --git a/connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/request/connection/UriConnection.java b/connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/request/connection/UriConnection.java index bdbfe10516..79b8c3dd61 100644 --- a/connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/request/connection/UriConnection.java +++ b/connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/request/connection/UriConnection.java @@ -25,9 +25,8 @@ public record UriConnection( @TemplateProperty( group = "connection", label = "URI", - defaultValue = "jdbc:postgresql://localhost:5432/mydb", description = - "URI should contain JDBC driver, username, password, host name, and port number. See the documentation.)") + "URI should contain JDBC driver, username, password, host name, and port number. For more information, see the documentation.)") String uri, @TemplateProperty( group = "connection",