Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on duplicate key in custom headers #4

Closed
pihme opened this issue Jun 27, 2022 · 3 comments · Fixed by #12
Closed

Warn on duplicate key in custom headers #4

pihme opened this issue Jun 27, 2022 · 3 comments · Fixed by #12
Assignees
@pinussilvestrus
Labels
enhancement New feature or request spring cleaning Could be cleaned up one day

Comments

@pihme
Copy link

pihme commented Jun 27, 2022 •
edited
Loading

In Camunda 8/Zeebe one can define custom headers for

  • Service Tasks
  • User Tasks
  • Send Tasks
  • Script Tasks
  • Message Intermediate Throw Events

If the custom headers contain entries with duplicate keys, this is an error and will be rejected on deployment.

image

Related to camunda/camunda#9416
@pihme pihme added the enhancement New feature or request label Jun 27, 2022
@pinussilvestrus pinussilvestrus added backlog Queued in backlog spring cleaning Could be cleaned up one day labels Jul 14, 2022
@pinussilvestrus pinussilvestrus self-assigned this Aug 14, 2022
@pinussilvestrus pinussilvestrus added in progress Currently worked on and removed backlog Queued in backlog labels Aug 15, 2022
@pinussilvestrus
Copy link
Contributor

@pihme @saig0, for which Zeebe Version should the linting be added? 8.1, 8.0, or even beforehand?

@pihme
Copy link
Author

pihme commented Aug 15, 2022

Ideally beforehand. Was always an error, we just didn't deal with it in a nice way.
What is the first version for which you support linting? How do you even differentiate the versions in modeler?

@pinussilvestrus
Copy link
Contributor

The engine + version needs to be set via modeler:executionPlatform and modeler:executionPlatformVersion in the diagram. The linting applies the rules to this version.

The Modeler can configure these properties accordingly, e.g. in the Desktop Modeler

image

I think that's handled similarly in the Web Modeler. @philippfromme please correct me if I'm wrong.

pinussilvestrus pushed a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Aug 15, 2022
feat(rules): add duplicate-task-headers rule
d6b923e 
Related to camunda/linting#4
This was referenced Aug 15, 2022
Merged
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 15, 2022
@nikku nikku added the in progress Currently worked on label Aug 18, 2022 — with bpmn-io-tasks
@nikku nikku removed the needs review Review pending label Aug 18, 2022
pinussilvestrus pushed a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Aug 18, 2022
@philippfromme
feat(rules): add duplicate-task-headers rule
4eb57f1 
Related to camunda/linting#4
Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 18, 2022
philippfromme added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Aug 18, 2022
@philippfromme
feat(rules): add duplicate-task-headers rule
0c71398 
Related to camunda/linting#4
Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>
philippfromme added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Aug 18, 2022
@philippfromme
feat(rules): add duplicate-task-headers rule
7e70764 
Related to camunda/linting#4
Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>
philippfromme added a commit that referenced this issue Aug 18, 2022
@philippfromme
feat: adjust error message for duplicate-task-headers rule
9c5f1f7 
Closes #4
Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>
philippfromme added a commit that referenced this issue Aug 18, 2022
@philippfromme
feat: adjust error message for duplicate-task-headers rule
f545506 
Closes #4
Co-authored-by: Niklas Kiefer <niklas.kiefer@camunda.com>
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
enhancement New feature or request spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set error message for duplicate-task-headers rule camunda/linting
3 participants
@nikku @pinussilvestrus @pihme