Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(benchmark): fail make on error #8952

Merged
merged 1 commit into from Mar 22, 2022

Conversation

falko
Copy link
Member

@falko falko commented Mar 22, 2022

Description

Remove suppression of errors from benchmark Makefile for installation tasks. For cleanup tasks they are necessary.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks falko 👍 🪀

bors r+

ghost pushed a commit that referenced this pull request Mar 22, 2022
8952: feat(benchmark): fail make on error r=Zelldon a=falko

## Description

Remove suppression of errors from benchmark Makefile for installation tasks. For cleanup tasks they are necessary.



Co-authored-by: Falko Menge <falko.menge@camunda.com>
@ghost
Copy link

ghost commented Mar 22, 2022

Build failed:

@Zelldon Zelldon merged commit 5079eff into camunda:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants