Make view results button visible on DomainCard for unauth'd users #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FestiveKyle
requested changes
Jun 22, 2023
Comment on lines
+207
to
+219
| <Button | ||
| variant="primary" | ||
| as={RouteLink} | ||
| to={{ | ||
| pathname: isLoggedIn() ? `/domains/${url}` : '/sign-in', | ||
| state: { from: location.pathname }, | ||
| }} | ||
| px="10" | ||
| > | ||
| <Text whiteSpace="noWrap"> | ||
| <Trans>View Results</Trans> | ||
| </Text> | ||
| </Button> |
There was a problem hiding this comment.
Thoughts on disabling button if userHasPermission === false, possibly also changing text to some form of Not Affiliated ?
FestiveKyle
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described, to ensure users know this is an option they can receive upon login and affiliation