Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid breaking developer builds during gen-code integration #334

Merged
merged 1 commit into from Feb 1, 2020

Conversation

jcburley
Copy link
Contributor

@jcburley jcburley commented Feb 1, 2020

Various changes made in the gen-code branch not only produce additional a_*code.go files, but change the way a_*data.go files are generated.

So it's best to start with a clean slate before running go generate ./..., to prevent it picking up those stale files.

Another approach to this could be to use build tags so go generate-run tools don't pick up any a_*.go files at all, but this seems easier and more effective.

@candid82
Copy link
Owner

candid82 commented Feb 1, 2020

Thanks!

@candid82 candid82 merged commit a0ae124 into candid82:master Feb 1, 2020
@jcburley jcburley deleted the avoid-breaking-master-build branch February 1, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants