1370508: Custom products in Activation key are not subscribed when service_level is set #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you go ahead an merge the commits? |
Previously this scenario was blocked by rule. Seems that a product without a support_level attribute should be usable by anyone, not just those without a service level assignment. In addition, 3 spec tests added in order to verify correct behavior.
pjonastik
force-pushed
the
pjonasti/1370508
branch
from
0aa7df5
to
7ceaab6
Compare
|
@wottop I've merged commits. |
wottop
reviewed
Sep 15, 2016
| sub_custom_product = @cp.create_subscription(@owner['key'], custom_product['id'], 30) | ||
|
|
||
| # creating in order to be able set SLA on activation key | ||
| premium_product = create_product('testp2', 'testp2', {:attributes => {:support_level => 'Premium'}}) |
There was a problem hiding this comment.
This product has a support level set, but the test says 'custom product without SLA'
There was a problem hiding this comment.
There are two products: with SLA set = premium_product and without SLA set = custom_product.
In test you can see that only custom_product is assigned to activation_key.
Premium_product exists (as comment above explain) because of setting SLA on activation key. It's not possible set SLA on activation key to 'Premium' value without creation of subscription of premium_product.
|
ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.