[M] Added grace period for product deletion during refresh/import (ENT-4881) #3341
Conversation
nikosmoum
requested review from
a team and
nikosmoum
and removed request for
a team
|
For this implementation, I opted to keep the configuration aspect as the CandlepinPoolManager level, but I could see an argument to moving the config parsing lower. There's no real concrete reasoning behind the decision to how it landed, so if this doesn't jive with others or someone feels strongly about doing it a different way, I'm open to suggestions. |
|
Edit: nm, did it today |
Ceiu
force-pushed
the
crog/m/product_deletion_grace_period
branch
from
1f65e39
to
0e6aac8
Compare
|
@nikosmoum I've updated one unit test I saw that was lacking a check, but was there anything specific you wanted to see tested or an idea you had for the spec tests? |
|
I just think it's good practice to have spec test for any feature/behavior, but you are right that there isn't a way to do this now except DB manipulation, so nevermind |
Ceiu
force-pushed
the
crog/m/product_deletion_grace_period
branch
from
0e6aac8
to
7906d94
Compare
- Products orphaned during refresh or manifest import can now have a grace period before they will be deleted - Added the config "candlepin.refresh.orphaned_entity_grace_period" to control the duration of the grace period in days, or disable it entirely. By default this option is set to 30 days.
Ceiu
force-pushed
the
crog/m/product_deletion_grace_period
branch
from
7906d94
to
fd88cab
Compare
|
Empty test filled in, a missing test was added, other tests updated accordingly. |
…ociation Candlepin may delete products if entitlements are removed from the manifest (c.f. candlepin/candlepin#3341 ). This leads to an issue in Katello once the entitlements are restored to the manifest; contents get recreated in Candlepin but Katello needs to tell it once again which environments should have access to which contents.
…ociation Candlepin may delete products if entitlements are removed from the manifest (c.f. candlepin/candlepin#3341 ). This leads to an issue in Katello once the entitlements are restored to the manifest; contents get recreated in Candlepin but Katello needs to tell it once again which environments should have access to which contents.
…ociation Candlepin may delete products if entitlements are removed from the manifest (c.f. candlepin/candlepin#3341 ). This leads to an issue in Katello once the entitlements are restored to the manifest; contents get recreated in Candlepin but Katello needs to tell it once again which environments should have access to which contents.
…ociation Candlepin may delete products if entitlements are removed from the manifest (c.f. candlepin/candlepin#3341 ). This leads to an issue in Katello once the entitlements are restored to the manifest; contents get recreated in Candlepin but Katello needs to tell it once again which environments should have access to which contents.
…ociation Candlepin may delete products if entitlements are removed from the manifest (c.f. candlepin/candlepin#3341 ). This leads to an issue in Katello once the entitlements are restored to the manifest; contents get recreated in Candlepin but Katello needs to tell it once again which environments should have access to which contents.
…ociation (#10192) Candlepin may delete products if entitlements are removed from the manifest (c.f. candlepin/candlepin#3341 ). This leads to an issue in Katello once the entitlements are restored to the manifest; contents get recreated in Candlepin but Katello needs to tell it once again which environments should have access to which contents.
…ociation (Katello#10192) Candlepin may delete products if entitlements are removed from the manifest (c.f. candlepin/candlepin#3341 ). This leads to an issue in Katello once the entitlements are restored to the manifest; contents get recreated in Candlepin but Katello needs to tell it once again which environments should have access to which contents. (cherry picked from commit e6a94f4)
…ociation (#10192) Candlepin may delete products if entitlements are removed from the manifest (c.f. candlepin/candlepin#3341 ). This leads to an issue in Katello once the entitlements are restored to the manifest; contents get recreated in Candlepin but Katello needs to tell it once again which environments should have access to which contents. (cherry picked from commit e6a94f4)
have a grace period before they will be deleted
to control the duration of the grace period in days, or disable
it entirely. By default this option is set to 30 days.