Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M] Added same-ID entity version collision resolution (ENT-5324) #3519

Merged
merged 1 commit into from Aug 19, 2022

Conversation

Ceiu
Copy link
Contributor

@Ceiu Ceiu commented Aug 18, 2022

  • The versioned entity update logic will now clear the entity version
    for an existing entity on collision when the colliding entities
    have the same entity ID

- The versioned entity update logic will now clear the entity version
  for an existing entity on collision when the colliding entities
  have the same entity ID
@nikosmoum nikosmoum requested review from a team and nikosmoum and removed request for a team August 18, 2022 18:35
@Ceiu
Copy link
Contributor Author

Ceiu commented Aug 18, 2022

A great deal of care should be taken when reviewing and evaluating this code. Getting the versioning wrong only leads to pain, so please pose any questions in logic, no matter how minor.

@nikosmoum nikosmoum merged commit 9ff4078 into master Aug 19, 2022
2 checks passed
@nikosmoum nikosmoum deleted the crog/m/entity_version_collision_resolution branch August 19, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants