Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[M] 2128583: Updated GuestIdDeserializer to use existing ObjectMapper (ENT-5422) #3608

Merged
merged 1 commit into from Oct 4, 2022
Merged

[M] 2128583: Updated GuestIdDeserializer to use existing ObjectMapper (ENT-5422) #3608

merged 1 commit into from Oct 4, 2022

Conversation

JoshAlbrecht23
Copy link
Contributor

@JoshAlbrecht23 JoshAlbrecht23 commented Sep 30, 2022 •
edited

  • Updated GuestIdDeserializer to use existing ObjectMapper

This is a fix for the original PR (#3606) for the issue

@nikosmoum nikosmoum requested review from a team and bakajstep and removed request for a team September 30, 2022 18:02
@JoshAlbrecht23 JoshAlbrecht23 changed the title [M] 2128583: Updated changes to original PR #3606 (ENT-5422) [M] 2128583: Updated GuestIdDeserializer to use existing ObjectMapper (ENT-5422) Sep 30, 2022
Ceiu
Ceiu requested changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@Ceiu Ceiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three minor changes would be nice, but won't affect functionality. Also we should have a third person review this since the PR contains code both of us have written.

src/main/java/org/candlepin/jackson/GuestIdDeserializer.java Show resolved Hide resolved
src/main/java/org/candlepin/jackson/GuestIdDeserializer.java Outdated Show resolved Hide resolved
src/main/java/org/candlepin/jackson/GuestIdDeserializer.java Outdated Show resolved Hide resolved
@nikosmoum nikosmoum merged commit 05d29b1 into master Oct 4, 2022
1 check passed
@nikosmoum nikosmoum deleted the jalbrech/m/ENT-5422 branch October 4, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikosmoum nikosmoum nikosmoum approved these changes

@Ceiu Ceiu Ceiu approved these changes

@bakajstep bakajstep Awaiting requested review from bakajstep bakajstep was automatically assigned from candlepin/candlepin-server

Assignees
No one assigned
Labels
Needs Second Review
Projects
None yet
Milestone
No milestone
3 participants
@JoshAlbrecht23 @nikosmoum @Ceiu