Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.1] 2131997: Added deserializer for GuestIdDTO (ENT-5422) #3611

Merged
merged 2 commits into from Oct 4, 2022
Merged

[4.1] 2131997: Added deserializer for GuestIdDTO (ENT-5422) #3611

merged 2 commits into from Oct 4, 2022

Conversation

JoshAlbrecht23
Copy link
Contributor

  • deserializer that creates GuestIdDTO from id string
  • deserializer that creates GuestIdDTO from containing object
  • updated GuestIdDeserializer to use existing ObjectMapper

@nikosmoum nikosmoum requested review from a team and Ceiu and removed request for a team October 4, 2022 14:03
@JoshAlbrecht23 JoshAlbrecht23 force-pushed the jalbrech/4.1/ENT-5422 branch 2 times, most recently from 0fb1d36 to e8f0fda Compare October 4, 2022 14:25
nikosmoum
nikosmoum requested changes Oct 4, 2022
View reviewed changes
Copy link
Member

@nikosmoum nikosmoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits should have the 4.1 BZ id: 2131997

@JoshAlbrecht23 JoshAlbrecht23 changed the title [4.1] 2128583: Added deserializer for GuestIdDTO (ENT-5422) [4.1] 2131997: Added deserializer for GuestIdDTO (ENT-5422) Oct 4, 2022
@JoshAlbrecht23
2131997: Added deserializer for GuestIdDTO
405510d 
- deserializer that creates GuestIdDTO from id string
- deserializer that creates GuestIdDTO from containing object
@JoshAlbrecht23
2131997: Updated GuestIdDeserializer to use existing ObjectMapper
9f600d4
@Ceiu Ceiu merged commit 091c4aa into candlepin-4.1-HOTFIX Oct 4, 2022
1 check passed
@Ceiu Ceiu deleted the jalbrech/4.1/ENT-5422 branch October 4, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikosmoum nikosmoum nikosmoum approved these changes

@Ceiu Ceiu Awaiting requested review from Ceiu Ceiu was automatically assigned from candlepin/candlepin-server

Assignees
No one assigned
Labels
merge after CI
Projects
None yet
Milestone
No milestone
3 participants
@JoshAlbrecht23 @nikosmoum @Ceiu