Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2172538: Fix setting of metadata expiration during import #3863

Merged
merged 1 commit into from Feb 27, 2023
Merged

2172538: Fix setting of metadata expiration during import #3863

merged 1 commit into from Feb 27, 2023

Conversation

Januson
Copy link
Contributor

@Januson Januson commented Feb 23, 2023

No description provided.

nikosmoum
nikosmoum requested changes Feb 23, 2023
View reviewed changes
Copy link
Member

@nikosmoum nikosmoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to add a spec test for the specific scenario.
Also, let's amend the commit msg to start with the cloned 4.1 BZ id to make sure automation can update bugzillas during release

src/test/java/org/candlepin/sync/ProductImporterTest.java Show resolved Hide resolved
@Januson Januson changed the title Backport of importer fixes 2172538: Fix setting of metadata expiration during import Feb 23, 2023
@nikosmoum nikosmoum merged commit 4d99883 into candlepin:candlepin-4.1-HOTFIX Feb 27, 2023
1 check passed
@Januson Januson deleted the ojanus/4.1/metadata branch March 2, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikosmoum nikosmoum nikosmoum approved these changes

Assignees
No one assigned
Labels
merge after CI
Projects
None yet
Milestone
No milestone
2 participants
@Januson @nikosmoum