1366523: Ensure that each quantity spinner has proper settings #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cell_renderer.set_property("adjustment", | ||
| ga_Gtk.Adjustment(lower=int(increment), upper=int(available), step_incr=int(increment))) | ||
| else: | ||
| self.quantity_renderer.set_property("adjustment", |
There was a problem hiding this comment.
self.quantity_renderer is cell_renderer. Please use cell_renderer in both places for consistency.
If you don't set the parameters on each spinner, it will bleed over from another one.
wottop
force-pushed
the
wottop/1366523
branch
from
e4dfabc
to
98b5dce
Compare
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you don't set the parameters on each spinner, it will bleed over
from another one.