Output the hostname of the system that was registered along with the UUID

[tonyjames]

This patch resolves BZ 1463325 which is a request for subscription-manager to output the hostname of the system that was registered along with the uuid.

[candlepin-bot]

Can one of the admins verify this patch?

[jirihnidek]

https://bugzilla.redhat.com/show_bug.cgi?id=1463325

[kahowell]

ok to test

[kahowell]

@tonyjames thanks for the PR.

FYI, this will need some changes before we merge it; in addition to inline comments:

• commit message should contain the BZ# (I'll suggest commit subject: "1463325: Output consumer name on registration")
• some unit tests need to be updated; test.test_registration.CliRegistrationTests fails with KeyError: 'consumer_name'

If you'd like you can make these changes, or my team can pick it up. Thoughts?

[kahowell]

Please remove the trailing space after %s.

Parentheses are a little out of order. Should be

print(_("The registered system name is: %s") % consumer_info["consumer_name"])

Please notice the parentheses are different - with what was there it was being interpreted as

(
    print(_("The registered system name is: %s"))  # statement result: None
    %
    consumer_info["consumer_name"]  # statement result: hostname
)  # unsupported operand type(s) for %: 'NoneType' and 'unicode'

(the print was happening before interpolation), rather than

print(
    _("The registered system name is: %s")
    %
    consumer_info["consumer_name"]
)

where the print happens after interpolation, as intended.

[tonyjames]

@kahowell I just pushed another commit with your suggested changes.

[kahowell]

a5b65c6..e2daa7a: fix failing unit test, squash

@tonyjames, ack. Looks good. I went ahead and made a small, necessary test fix, and squashed to a single commit. Once the Jenkins tests pass, I'll merge.