1507158: Provide Host: in http CONNECT header #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahowell
suggested changes
Nov 27, 2017
src/rhsm/connection.py
Outdated
| proxy_headers = {'User-Agent': self.user_agent} | ||
| proxy_headers = { | ||
| 'User-Agent': self.user_agent, | ||
| 'Host': '%s:%s' % (self.host, safe_int(self.ssl_port)) |
There was a problem hiding this comment.
Please normalize host for IPv6 compatibility as in #1725. (See
subscription-manager/src/rhsm/connection.py
Lines 327 to 334 in be328f0
kahowell
approved these changes
Nov 28, 2017
|
@jirihnidek looks good. Please squash. |
* Bug fix: https://bugzilla.redhat.com/show_bug.cgi?id=1507158 * Handle properly situation, when proxy server uses IPv6 address and we don't use hostname of proxy server only IPv6 address * TODO: verify this bug fix with proxy server requiring this header. Waiting for more info from BZ reporter.
jirihnidek
force-pushed
the
jhnidek/1507158
branch
from
bece610
to
fc31721
Compare
|
@kahowell squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
header. Waiting for more info from BZ reporter.