Sync the syspurpose on runs of each relevant command #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@candlepin-pull-request-bot please retest this. |
|
When I run locally, I get optparse.OptionConflictError: option --set: conflicting option string(s): --set |
|
@wottop That is fixed now. Along with other updates! Will ask @jirihnidek for review in the meanwhile as he'll be on before us tomorrow. |
|
@cnsnyder I try to fix most of issues in this PR. |
|
@cnsnyder I tried to fix several issues. Some unit tests are still falling. I will try to fix it later. |
cnsnyder
force-pushed
the
csnyder/ENT-767
branch
from
f6a39cb
to
1a3579d
Compare
jirihnidek
force-pushed
the
csnyder/ENT-767
branch
from
1a3579d
to
f6a39cb
Compare
wottop
reviewed
Aug 15, 2018
|
|
||
| def set(self): | ||
| self._set(self.options.set) | ||
| success_msg = "{attr} set to \"{val}\".".format(attr=self.attr, val=self.options.set) |
|
|
||
| def add(self): | ||
| self._add(self.options.to_add) | ||
| success_msg = "{attr} updated.".format(attr=self.name) |
|
|
||
| def unset(self): | ||
| self._unset() | ||
| success_msg = "{attr} unset.".format(attr=self.attr) |
|
|
||
| def remove(self): | ||
| self._remove(self.options.to_remove) | ||
| success_msg = "{attr} updated.".format(attr=self.name.capitalize()) |
| # help=_("service level to apply to this system")) | ||
| # self.parser.add_option("--unset", dest="unset", | ||
| # action='store_true', | ||
| # help=_("unset the service level for this system")) | ||
|
|
There was a problem hiding this comment.
Are we keeping these as comments for a reason?
|
@candlepin-pull-request-bot Retest this please |
2 similar comments
|
@candlepin-pull-request-bot Retest this please |
|
@candlepin-pull-request-bot Retest this please |
cnsnyder
force-pushed
the
csnyder/ENT-767
branch
from
86a80c3
to
c13a0ca
Compare
|
@candlepin-pull-request-bot Retest this please |
* When system purpose is changed using followinf subcommands: service-level, role, usage, addons, then system purpose is synchronized with candlepin server * TODO: fix debug log of report message for this case
cnsnyder
force-pushed
the
csnyder/ENT-767
branch
from
c13a0ca
to
c1927ba
Compare
|
ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revises the Role, Usage, Addons, and ServiceLevel Commands.
Each of these now perform the sync action and display a message with a course of action if the result is not as expected.
The way to get this message to show up is in the reproducer steps in This bug