1725525: Better translation of syspurpose; ENT-1680 #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1725525 * One string was not marked for localization * Many strings had bad ending of function _("string"). - When the string contains something like this: "{attr}".format(attr=some_variable), then the _() has to be used like this: _("{attr}").format(attr=some_variable) and not like this: _("{attr}".format(attr=some_variable)) The second case is wrong, because gettext will try to find translation for string that is included in some_variable.
jirihnidek
force-pushed
the
jhnidek/1725525
branch
from
77dab48
to
f0f7611
Compare
jirihnidek
changed the title
|
Issues in following bugs should be fixed in this PR too. |
cnsnyder
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"{attr}".format(attr=some_variable), then the _()
has to be used like this:
_("{attr}").format(attr=some_variable)
and not like this:
_("{attr}".format(attr=some_variable))
The second case is wrong, because gettext will try to find
translation for string that is included in some_variable.