1894450: Fix issue with identity command; ENT-3235 #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1894450 * The subscription-manager identity returned wrong values after removing consumer from candlepin server. When there was cache file /var/lib/rhsm/cache/current_owner.json, then the identity command only returned content of this cache file. * The cache file can be used, when previous REST API call using consumer cert/key was successful and the validity of consumer UUID was proved. * Added several unit tests
|
Please take a look at the failing tests. I think we'll need a way to mock filesystem access by the cache during the new tests. |
Interesting. It wasn't failing on my computer. Of course, I will fix it. |
cnsnyder
approved these changes
Dec 3, 2020
Lorquas
pushed a commit
that referenced
this pull request
Jun 9, 2021
* 1894450: Fix issue with identity command; ENT-3235 * BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1894450 * The subscription-manager identity returned wrong values after removing consumer from candlepin server. When there was cache file /var/lib/rhsm/cache/current_owner.json, then the identity command only returned content of this cache file. * The cache file can be used, when previous REST API call using consumer cert/key was successful and the validity of consumer UUID was proved. * Added several unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing consumer from candlepin server. When there was
cache file /var/lib/rhsm/cache/current_owner.json, then
the identity command only returned content of this cache
file.
using consumer cert/key was successful and the validity
of consumer UUID was proved.