ENT-2779: call format() on translated string #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnsnyder
requested review from
a team and
cnsnyder
and removed request for
a team
ptoscano
force-pushed
the
ptoscano/ENT-2779
branch
from
fee291b
to
e0ff8f7
Compare
Replace the placeholders in the translated string rather than the English string, as the English string with replacements cannot be translated. RHBZ: 1663390, 1663402, 1663429 Card ID: ENT-2779
ptoscano
force-pushed
the
ptoscano/ENT-2779
branch
from
e0ff8f7
to
b5f9bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the placeholders in the translated string rather than the
English string, as the English string with replacements cannot be
translated.
RHBZ: 1663390, 1663402, 1663429
Card ID: ENT-2779