2023257: Disallowed attaching pool in SCA mode: #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnsnyder
requested review from
a team and
ptoscano
and removed request for
a team
jirihnidek
force-pushed
the
jhnidek/2023257
branch
from
9f628e4
to
9b39b16
Compare
cnsnyder
requested changes
Nov 22, 2021
|
minor note: the message of the second commit has a typo: "Dissalowed" -> "Disallowed" |
* Card ID: ENT-1415 * Manual attaching of pool using --pool CLI option is not allowed now. When user tries to attach any pool in SCA mode, then info message is printedn and subscription-manager is terminated * Added two unit tests for auto-attach ins SCA mode and manual attach * Added more debug prints for cache used by function is_simple_content_access(), because I considered using this method, when --help is used, but calling subscription-manager attach --help would cause calling one REST API endpoint * Updated manual page about subscription-manager
* Card ID: ENT-1415 * When D-Bus methods AutoAttach() or PoolAttach() are called in SCA mode, then exception is raised * Added two unit tests for this case
jirihnidek
force-pushed
the
jhnidek/2023257
branch
from
9b39b16
to
29d8000
Compare
|
Thanks for reviews. Commits are updated. |
|
LGTM; I'll leave it to @cnsnyder for his final look. |
cnsnyder
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowed now. When user tries to attach any pool in SCA
mode, then info message is printedn and subscription-manager
is terminated
manual attach
is_simple_content_access(), because I considered using
this method, when --help is used, but calling
subscription-manager attach --help would cause calling
one REST API endpoint