[1.24] Update RestlibException error reporting #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent changes to RefreshCommand make use of ExceptionMapper in a place where it was not used previously. While using ExceptionMapper is generally a good idea to format errors, in this case the consistency with the behaviour of a maintenance branch is preferred. Hence, manually print again the message of RestlibException. Updates commit 3b3eda2.
The newly added get_current_owner() helper uses handle_exception() for all the exceptions, whereas the expectation for this maintenance branch is that the message of RestlibException is printed as is. Hence, add a special handling for RestlibException in get_current_owner(). Updates commit c4c120a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent PRs in the 1.24 branch (#3261 & #3271) changed how a
RestlibExceptionis formatted when exiting with an error; since 1.24 is a long-lived maintenance branch, the expectation is that the error reporting stays unchanged when possible.Hence, update the error reporting for
RestlibExceptionin a couple of places to be back how it used to be before commit 3b3eda2 & commit c4c120a.