Reusing existing ObjectMapper in RestJsonClient.

Don't create new ObjectMapper's - one is sufficient. ObjectMapper.readValue can use an InputStream directly, no need to convert to String first.
candrews · Aug 24, 2011 · 5052e7c · 5052e7c · talklittle · Sep 7, 2011
1 parent 34d5930
commit 5052e7c
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/com/andrewshu/android/reddit/common/RestJsonClient.java b/src/com/andrewshu/android/reddit/common/RestJsonClient.java
@@ -26,7 +26,7 @@ public static JsonNode connect(String url)
         // Execute the request
         HttpResponse response;
 
-        ObjectMapper json = new ObjectMapper();
+        ObjectMapper json = Common.getObjectMapper();
         JsonNode data = null;
         try {
             response = httpclient.execute(httpget);
@@ -37,10 +37,8 @@ public static JsonNode connect(String url)
 
                 // A Simple JSON Response Read
                 InputStream instream = entity.getContent();
-                String result= convertStreamToString(instream);
 
-                json = new ObjectMapper();
-                data = json.readValue(result, JsonNode.class);
+                data = json.readValue(instream, JsonNode.class);
 
                 instream.close();
             }