New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTION] Compatibility of classes packages with the locations of java files #15

Merged
merged 1 commit into from Apr 22, 2013

Conversation

Projects
None yet
3 participants
@PBastiani
Contributor

PBastiani commented Feb 7, 2012

Hello Chris,

In the generated projects, the locations of Java files are not consistent with the Java standard :

In the archetype

  • the java classes are tagged with the $package variable
  • in the archetype-metadata.xml file, the filesets are not defined with the 'packaged' attribute.
    Therefore, for the EclipseColorTheme sample project:
  • the java files are copied into 'org/aniszczyk/minerva'
  • the classes are defined with the com.github.eclipsecolortheme package.

So, I propose:

  • to delete the 3 levels 'org','aniszczyk','minerva'
  • to update the definition of each fileset.

If you accept, I can pull a request...

Closes #15: enabling fileset packaging.
Note: this commit replaces the previous ones (PR19 for reference)
@belaso

This comment has been minimized.

belaso commented Apr 17, 2013

Hi Chris,

the java files are copied into 'org/aniszczyk/minerva'

this makes this archetype a little awkward, the proposed change whould be awesome 👍

Christian

caniszczyk added a commit that referenced this pull request Apr 22, 2013

Merge pull request #15 from PBastiani/issue15
[SUGGESTION] Compatibility of classes packages with the locations of java files

@caniszczyk caniszczyk merged commit 8c7e1fc into caniszczyk:master Apr 22, 2013

@caniszczyk

This comment has been minimized.

Owner

caniszczyk commented Apr 22, 2013

Thanks, sorry took so long to get to this.

@PBastiani PBastiani deleted the PBastiani:issue15 branch May 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment