Gulp Task Added #17

Merged
merged 8 commits into from Feb 17, 2014

Conversation

Projects
None yet
2 participants
Owner

marshallswain commented Feb 17, 2014

Enables really convenient syntax for using with Gulp.js. Allows for all of the same options.

Had to move the main function outside of index.js in order to avoid a circular reference. So, instead of

module.exports = function(....

it is now

module.exports = require('entry.js');

... where entry.js contains the same exact original function and dependencies.

marshallswain added some commits Feb 16, 2014

@marshallswain marshallswain Added an example of using can-compile with Gulp.js 11a0318
@marshallswain marshallswain Update readme.md 19ea0de
@marshallswain marshallswain Gulp compatibility.
Added gulp/gulp.js to allow easy utilization of can-compile inside a
gulpfile.

Had to move the main function out of index.js and into its own file to
get rid of the circular dependency.  All functionality should remain
the same.
ca96a4b
Owner

marshallswain commented Feb 17, 2014

I'm not sure that we need to put gulp.js in its own directory. Would it mess up Grunt to put it in the tasks folder?

marshallswain added some commits Feb 17, 2014

@marshallswain marshallswain Cleaned up a bit.
Restored index.js to its original state.

Now must require the task directly from tasks folder.

    var compileGulp = require(‘can-compile/tasks/gulp.js’)

Updated readme.md to match.
3b6fe78
@marshallswain marshallswain Removed straggling requires. edd7b1c
Collaborator

daffl commented Feb 17, 2014

I'm not sure if it would mess with Grunt. The easiest way to avoid any issues is probably to move the gulp.js file to the top level (since you can load them from any location anyway). Besides that it looks great, thanks!

Owner

marshallswain commented Feb 17, 2014

Done. Works like a charm.

marshallswain added some commits Feb 17, 2014

@marshallswain marshallswain Fixed a type & clarified.
I tried a few times to compile an array of files “Programmatically”
until I read through the source code and found that it wasn’t intended
to work that way. :)
8788263
@marshallswain marshallswain Clarified instructions for new-comers. df80dc6
Collaborator

daffl commented Feb 17, 2014

Awesome! I'll get a new release out this week.

@daffl daffl added a commit that referenced this pull request Feb 17, 2014

@daffl daffl Merge pull request #17 from marshallswain/patch-2
Gulp Task Added
f8d3b4f

@daffl daffl merged commit f8d3b4f into canjs:master Feb 17, 2014

1 check passed

default The Travis CI build passed
Details

marshallswain deleted the marshallswain:patch-2 branch Feb 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment