Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can-dom-events/helpers/add-event-jquery breaks can-jquery #159

Closed
pYr0x opened this Issue Dec 18, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@pYr0x
Copy link

commented Dec 18, 2017

with this PR can-jquery gets broken: bff0afc

here is the error message:

TypeError: Cannot read property 'removed' of undefined
    at HTMLFieldSetElement.domEvents.addEventListener (can-jquery.js:76)
    at Constructor.on (can-control.js:355)
    at Constructor.setup (can-control.js:323)
    at Function.newInstance (can-construct.js:288)
    at Constructor.init (can-construct.js:636)
    at new Constructor (eval at <anonymous> (can-construct.js:NaN), <anonymous>:3:34)
    at execute (import2_import.js:10)
    at doExecute (steal.js:2158)
    at ensureEvaluated (steal.js:2205)
    at doEnsureEvaluated (steal.js:2168)

!domEvents._compatRegistry gets undefined in

if(!inSpecial && !domEvents._compatRegistry[event]) {

simple example:

import $ from "can-jquery";
import Control from "can-control";

var Entnahmestellen = Control.extend({
});

new Entnahmestellen('#entnahmestellen');

cc @chasenlehara

@chasenlehara chasenlehara self-assigned this Dec 19, 2017

@chasenlehara

This comment has been minimized.

Copy link
Member

commented Dec 21, 2017

I started working on a fix for this today and should have an update tomorrow.

@chasenlehara

This comment has been minimized.

Copy link
Member

commented Dec 27, 2017

This should be fixed in 3.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.