Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix serialization (add assignDeepMap Symbol) #126

Closed
wants to merge 4 commits into from

Conversation

cherifGsoul
Copy link
Member

For #125

Copy link
Contributor

@phillipskevin phillipskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a test to reproduce the issue that happens with the can-reflect change?

Also, can you figure out why jshint is not working? There's a semicolon missing in the test change, but it looks like jshint didn't catch it for some reaosn.

@cherifGsoul
Copy link
Member Author

@phillipskevin I added assignDeepMap Symbol in order to not break the behavior after the changes in canReflect

@cherifGsoul cherifGsoul changed the title fix serialization fix serialization (add assignDeepMap Symbol) Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants