New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hasOwnKeys #27

Open
phillipskevin opened this Issue Nov 5, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@phillipskevin
Copy link
Contributor

phillipskevin commented Nov 5, 2018

It would be nice if you could serialize promises using can-reflect and have the virtual properties show up. Right now it doesn't do anything useful:

image

@justinbmeyer

This comment has been minimized.

Copy link
Contributor

justinbmeyer commented Nov 7, 2018

I’m not sure it should serialize to those values. It’s virtual properties should not be enumerable.

@phillipskevin

This comment has been minimized.

Copy link
Contributor

phillipskevin commented Nov 8, 2018

@justinbmeyer do you think we should just handle this in devtools? So that those properties show up in devtools but not in other places that use canReflect.serialize?

@justinbmeyer

This comment has been minimized.

Copy link
Contributor

justinbmeyer commented Nov 9, 2018

Can’t they be non-enumerable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment