New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Observations instead of computes #162

Closed
justinbmeyer opened this Issue Mar 3, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@justinbmeyer
Contributor

justinbmeyer commented Mar 3, 2017

It should be possible to use can-observation directly within can-stache and can-view-live where the compute is created here:

computeValue = compute(evaluator, null, false);

This should improve performance by about 10%.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Mar 3, 2017

Contributor

It should eliminate all the following calls:

canjs_v3_4_1

Contributor

justinbmeyer commented Mar 3, 2017

It should eliminate all the following calls:

canjs_v3_4_1

@matthewp

This comment has been minimized.

Show comment
Hide comment
@matthewp

matthewp Mar 3, 2017

Contributor

I still don't understand those profile tools. Where do you get 10% from that? I want to understand how to use those tools better.

Contributor

matthewp commented Mar 3, 2017

I still don't understand those profile tools. Where do you get 10% from that? I want to understand how to use those tools better.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Mar 3, 2017

Contributor

If you eliminate those calls, they add up to ~10% of the total execution time.

Contributor

justinbmeyer commented Mar 3, 2017

If you eliminate those calls, they add up to ~10% of the total execution time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment