Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addConverter is not documented #556

Closed
justinbmeyer opened this issue Jun 25, 2018 · 3 comments
Closed

addConverter is not documented #556

justinbmeyer opened this issue Jun 25, 2018 · 3 comments

Comments

@justinbmeyer
Copy link
Contributor

but registerConverter is, though I think addConverter is the more useful (and necessary) one that can actually do child->parent conversion. It actually adds isLiveBound:

https://github.com/canjs/can-stache/blob/master/helpers/converter.js#L24

Btw, do we need a better name for isLiveBound? Could we call it callWithObservableValues?

@phillipskevin
Copy link
Contributor

isLiveBound is bad, but I'm not sure what a better name would be. It's not really callWithObservableValues... It's just dontGetValueOfArguments.

if (doNotWrapArguments) {
finalArgs[i] = args[i].value;
} else {
finalArgs[i] = args[i].call ?
canReflect.getValue( args[i].value ) :
expressionHelpers.toCompute( args[i].value );
}

@justinbmeyer
Copy link
Contributor Author

https://canjs.com/doc/can-stache.registerConverter.html <- documented poorly

@chasenlehara
Copy link
Member

I think this can be closed because we have addConverter docs now: https://canjs.com/doc/can-stache.addConverter.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants