Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if <content/> already registred #322

Merged
merged 4 commits into from Oct 12, 2017

Conversation

Projects
None yet
3 participants
@cherifGsoul
Copy link
Member

commented Oct 6, 2017

this fixes #165

@@ -6271,6 +6271,12 @@ function makeTest(name, doc, mutation) {
equal(view.firstChild.lastChild.nodeValue, "yep", "Got aliased value");
});

test('check if <content> is already registred #165', function () {

This comment has been minimized.

Copy link
@phillipskevin

phillipskevin Oct 6, 2017

Contributor

I think to test this you'll need to register a content tag and then use steal-clone to re-import can-stache and make sure there is not a warning given that says content is already defined.

@cherifGsoul cherifGsoul changed the title check if <content/> already registred WIP: check if <content/> already registred Oct 9, 2017

@cherifGsoul cherifGsoul changed the title WIP: check if <content/> already registred check if <content/> already registred Oct 9, 2017

@imaustink imaustink self-requested a review Oct 12, 2017

@imaustink imaustink merged commit 57a1b32 into master Oct 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@imaustink imaustink deleted the check_content_tag_callback_already_exist branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.