From aa36cd4d87a42892d5f47476054c07717db5c6a4 Mon Sep 17 00:00:00 2001 From: Mark Stahl Date: Fri, 16 Mar 2018 11:44:11 -0400 Subject: [PATCH] Fixes #84. Removes the stringified regex from the warning message --- can-view-callbacks.js | 2 +- test/callbacks-test.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/can-view-callbacks.js b/can-view-callbacks.js index 4cf62fd..fa6b513 100644 --- a/can-view-callbacks.js +++ b/can-view-callbacks.js @@ -104,7 +104,7 @@ var attr = function (attributeName, attrHandler) { //!steal-remove-start Object.keys(requestedAttributes).forEach(function(requested){ if(attributeName.test(requested)) { - dev.warn("can-view-callbacks: " + requested+ " custom attribute behavior requested before it was defined. Make sure "+attributeName+" is defined before it is needed."); + dev.warn("can-view-callbacks: " + requested+ " custom attribute behavior requested before it was defined. Make sure "+requested+" is defined before it is needed."); } }); //!steal-remove-end diff --git a/test/callbacks-test.js b/test/callbacks-test.js index cc436d9..ebbd624 100644 --- a/test/callbacks-test.js +++ b/test/callbacks-test.js @@ -107,16 +107,16 @@ testHelpers.devOnlyTest("should warn if attr callback defined after attr request equal(teardown(), 1, "got warning"); }); -testHelpers.devOnlyTest("should warn if RegExp attr callback defined after attr requested (#57)", function () { +testHelpers.devOnlyTest("should warn if RegExp attr callback defined after attr requested (#57, #84)", function () { var attrName = "masonry-wall"; var attrMatch = /masonry[- ]?wall/; - var teardown = testHelpers.willWarn("can-view-callbacks: " + attrName+ " custom attribute behavior requested before it was defined. Make sure "+attrMatch.toString()+" is defined before it is needed."); + var teardown = testHelpers.willWarn("can-view-callbacks: " + attrName+ " custom attribute behavior requested before it was defined. Make sure "+attrName+" is defined before it is needed."); // calback attr requested callbacks.attr(attrName); // callback attr provided - callbacks.attr(attrMatch, function(){}); + callbacks.attr(attrMatch, function() {}); equal(teardown(), 1, "got warning"); });