From f72151d77862c4a140832c077607c5292e21f6e4 Mon Sep 17 00:00:00 2001 From: Chris Andrejewski Date: Fri, 29 Dec 2017 16:01:42 -0500 Subject: [PATCH 1/5] Update package.json --- build.js | 21 --------------------- package.json | 9 +++------ 2 files changed, 3 insertions(+), 27 deletions(-) delete mode 100644 build.js diff --git a/build.js b/build.js deleted file mode 100644 index 06382b8..0000000 --- a/build.js +++ /dev/null @@ -1,21 +0,0 @@ -var stealTools = require("steal-tools"); - -stealTools.export({ - steal: { - config: __dirname + "/package.json!npm" - }, - outputs: { - "+amd": {}, - "+standalone": { - exports: { - "can-namespace": "can" - } - } - } -}).catch(function(e){ - - setTimeout(function(){ - throw e; - },1); - -}); diff --git a/package.json b/package.json index 733c7a5..ed0c75d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "can-view-target", - "version": "3.1.6", + "version": "4.0.0-pre.0", "description": "Fast cloning micro templates", "homepage": "http://canjs.com", "repository": { @@ -13,9 +13,8 @@ "url": "http://bitovi.com" }, "scripts": { - "preversion": "npm test && npm run build", - "version": "git commit -am \"Update dist for release\" && git checkout -b release && git add -f dist/", - "postversion": "git push --tags && git checkout master && git branch -D release && git push", + "preversion": "npm test", + "postpublish": "git push --tags && git push", "testee": "testee test/test.html --browsers firefox", "test": "npm run detect-cycle && npm run jshint && npm run testee", "jshint": "jshint ./*.js --config", @@ -23,8 +22,6 @@ "release:patch": "npm version patch && npm publish", "release:minor": "npm version minor && npm publish", "release:major": "npm version major && npm publish", - "build": "node build.js", - "develop": "done-serve --static --develop --port 8080", "detect-cycle": "detect-cyclic-packages --ignore done-serve" }, "main": "can-view-target", From daeadc724bb7c09c5b28c331559f301b013c1cee Mon Sep 17 00:00:00 2001 From: Chris Andrejewski Date: Fri, 29 Dec 2017 16:05:34 -0500 Subject: [PATCH 2/5] 4.0.0-pre.1 --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index ed0c75d..801ef3e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "can-view-target", - "version": "4.0.0-pre.0", + "version": "4.0.0-pre.1", "description": "Fast cloning micro templates", "homepage": "http://canjs.com", "repository": { @@ -13,7 +13,7 @@ "url": "http://bitovi.com" }, "scripts": { - "preversion": "npm test", + "preversion": "npm test", "postpublish": "git push --tags && git push", "testee": "testee test/test.html --browsers firefox", "test": "npm run detect-cycle && npm run jshint && npm run testee", From 9da21a68ac1b376189820bb50d28ed9ed0134716 Mon Sep 17 00:00:00 2001 From: Justin Meyer Date: Sat, 27 Jan 2018 17:06:43 -0600 Subject: [PATCH 3/5] uses removes some unnecessary dev deps --- package.json | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 801ef3e..a63c1b4 100644 --- a/package.json +++ b/package.json @@ -31,12 +31,11 @@ "donejs" ], "dependencies": { - "can-dom-mutate": "<2.0.0", - "can-globals": "<2.0.0", + "can-dom-mutate": "^1.0.0", + "can-globals": "^2.0.0", "can-namespace": "1.0.0" }, "devDependencies": { - "bit-docs": "0.0.7", "can-simple-dom": "^1.0.2", "detect-cyclic-packages": "^1.1.0", "done-serve": "^1.0.0", @@ -45,7 +44,6 @@ "jshint": "^2.9.1", "steal": "^1.0.1", "steal-qunit": "^1.0.0", - "steal-tools": "^1.0.0", "testee": "^0.7.0" } } From e1dd79bb1e0ab494f8e67ceece57b73aee9f9397 Mon Sep 17 00:00:00 2001 From: Justin Meyer Date: Sat, 27 Jan 2018 17:09:07 -0600 Subject: [PATCH 4/5] make sur we publish the test folder --- .npmignore | 3 ++- .npmrc | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 .npmrc diff --git a/.npmignore b/.npmignore index 05a9d0c..56cedba 100644 --- a/.npmignore +++ b/.npmignore @@ -1 +1,2 @@ -!dist/ \ No newline at end of file +!dist/ +!test/ diff --git a/.npmrc b/.npmrc new file mode 100644 index 0000000..43c97e7 --- /dev/null +++ b/.npmrc @@ -0,0 +1 @@ +package-lock=false From 5ff86eb3e1d7721c11e3eb63427cde6a4ce42011 Mon Sep 17 00:00:00 2001 From: Justin Meyer Date: Sat, 27 Jan 2018 17:12:36 -0600 Subject: [PATCH 5/5] use can-dom-mutate correctly --- can-view-target.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/can-view-target.js b/can-view-target.js index b5eb31d..1bff54a 100644 --- a/can-view-target.js +++ b/can-view-target.js @@ -1,11 +1,7 @@ /* jshint maxdepth:7 */ /* jshint latedef:false */ -var childNodes = require('can-util/dom/child-nodes/child-nodes'); -var domAttr = require('can-util/dom/attr/attr'); -var each = require('can-util/js/each/each'); -var makeArray = require('can-util/js/make-array/make-array'); var getDocument = require('can-globals/document/document'); -var domMutate = require('can-util/dom/mutate/mutate'); +var domMutate = require('can-dom-mutate/node'); var namespace = require('can-namespace'); var MUTATION_OBSERVER = require('can-globals/mutation-observer/mutation-observer'); @@ -33,7 +29,7 @@ var processNodes = function(nodes, paths, location, document){ var cloned = testFrag.cloneNode(true); - return childNodes(cloned.firstChild).length === 2; + return cloned.firstChild.childNodes.length === 2; })(), clonesWork = typeof document !== "undefined" && (function(){ // Since html5shiv is required to support custom elements, assume cloning @@ -110,12 +106,13 @@ var cloneNode = clonesWork ? } if(node.attributes) { - var attributes = makeArray(node.attributes); - each(attributes, function (node) { - if(node && node.specified) { - domAttr.setAttribute(copy, node.nodeName || node.name, node.nodeValue || node.value); + var attributes = node.attributes; + for (var i = 0; i < attributes.length; i++) { + var attribute = attributes[i]; + if (attribute && attribute.specified) { + domMutate.setAttribute.call(copy, attribute.nodeName || attribute.name, attribute.nodeValue || attribute.value); } - }); + } } if(node && node.firstChild) { @@ -165,7 +162,7 @@ function processNode(node, paths, location, document){ callback: value }); } else { - domAttr.setAttribute(el, attrName, value); + domMutate.setAttribute.call(el, attrName, value); } } } @@ -264,7 +261,10 @@ function makeTarget(nodes, doc){ clone: frag, hydrate: function(){ var cloned = cloneNode(this.clone); - var args = makeArray(arguments); + var args = []; + for (var a = 0, ref = args.length = arguments.length; a < ref; a++) { + args[a] = arguments[a]; + } // see https://jsperf.com/nodelist-to-array var callbacks = []; for(var i = 0; i < paths.length; i++) {