Incomplete documentation for can.List.prototype.filter #1165

Closed
jawshooah opened this Issue Jul 14, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@jawshooah

It probably bears mentioning in the docs that the prototype method filter of can.Map.List overrides that of can.List, and does not take a second argument thisArg as the method in can.List does.

@jawshooah

This comment has been minimized.

Show comment
Hide comment
@jawshooah

jawshooah Jul 14, 2014

For that matter, there's no mention at all of can.Map.List.prototype.map in the docs.

For that matter, there's no mention at all of can.Map.List.prototype.map in the docs.

@justinbmeyer justinbmeyer added this to the 2.1.3 milestone Jul 23, 2014

@andykant andykant self-assigned this Jul 25, 2014

@andykant

This comment has been minimized.

Show comment
Hide comment
@andykant

andykant Jul 25, 2014

Contributor

I'll take a look at this, I believe there is also some vagueness in that some of this filter/sort support in Lists is via plugins when it isn't specified in the documentation as such.

Contributor

andykant commented Jul 25, 2014

I'll take a look at this, I believe there is also some vagueness in that some of this filter/sort support in Lists is via plugins when it isn't specified in the documentation as such.

@andykant

This comment has been minimized.

Show comment
Hide comment
@andykant

andykant Jul 31, 2014

Contributor

I added documentation for the can/map/list plugin. Is does indeed change the function signature for List.filter, so I added that information to the documentation as well.

Contributor

andykant commented Jul 31, 2014

I added documentation for the can/map/list plugin. Is does indeed change the function signature for List.filter, so I added that information to the documentation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment