New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getOwnPropertyDescriptor causes fatal error in IE8 #1378

Closed
debugwand opened this Issue Dec 22, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@debugwand

debugwand commented Dec 22, 2014

Within can/construct/construct.js, this line will throw an error in IE8
var descriptor = Object.getOwnPropertyDescriptor(newProps, name);

This is because IE8 will only support getOwnPropertyDescriptor on DOM objects but not user defined objects.
http://msdn.microsoft.com/en-us/library/ie/dd548686(v=vs.94).aspx

Versions affected: 2.1.4

IE7 works

Additional comment: took out all js files apart from jQuery and can.custom.js to check. Can.custom.js had been built with can.Map, which includes can.Construct.

@daffl daffl added the bug label Dec 26, 2014

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Dec 26, 2014

Contributor

Argh, I thought I tested this in IE8. I guess the solution is to feature detect this (see https://github.com/es-shims/es5-shim/blob/master/es5-sham.js#L73)

Contributor

daffl commented Dec 26, 2014

Argh, I thought I tested this in IE8. I guess the solution is to feature detect this (see https://github.com/es-shims/es5-shim/blob/master/es5-sham.js#L73)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment