New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.stache and can.mustache templates don't resolve partial names against the scope. #1389

Closed
john-charles opened this Issue Jan 2, 2015 · 1 comment

Comments

Projects
None yet
4 participants
@john-charles

john-charles commented Jan 2, 2015

This issue relates to and may have common cause with #1388

According to: http://canjs.com/docs/can.mustache.helpers.partial.html#section_PassingPartialsinOptions

When including a partial the name passed in is to be resolved first against the vm and then treated as a raw value if not found in the vm. This behavior does not happen, instead nothing happens, no attempt to load the template appears to be made, no exceptions are thrown.

This bug applies to can.stache templates.

Please see the following proof.
http://jsfiddle.net/johncharles/oayj40t9/2/

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Feb 11, 2015

Contributor

@john-charles

When including a partial the name passed in is to be resolved first against the vm and then treated as a raw value if not found in the vm.

What do you mean by "VM"? Do you mean view model? In stache / mustache terminology, I think you mean the can.view.Scope.

Ok, this is a bug. We will fix.

Contributor

justinbmeyer commented Feb 11, 2015

@john-charles

When including a partial the name passed in is to be resolved first against the vm and then treated as a raw value if not found in the vm.

What do you mean by "VM"? Do you mean view model? In stache / mustache terminology, I think you mean the can.view.Scope.

Ok, this is a bug. We will fix.

@justinbmeyer justinbmeyer added this to the 2.2.0 milestone Feb 11, 2015

@justinbmeyer justinbmeyer added the bug label Feb 11, 2015

@justinbmeyer justinbmeyer changed the title from can.stache templates don't resolve partial names against the scope. to can.stache and can.mustache templates don't resolve partial names against the scope. Feb 11, 2015

justinbmeyer added a commit that referenced this issue Feb 13, 2015

@cklanac cklanac closed this Feb 13, 2015

@daffl daffl removed the fixed in branch label Feb 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment