New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List.prototype.__set should not assume to create an array for indices out of bounds #1548

Closed
alexisabril opened this Issue Mar 24, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@alexisabril
Contributor

alexisabril commented Mar 24, 2015

This line: https://github.com/bitovi/canjs/blob/master/list/list.js#L144 assumes that creating items on a list, out of bounds, should create an array and set that value.

alexisabril added a commit that referenced this issue Mar 24, 2015

alexisabril added a commit that referenced this issue Mar 24, 2015

@pYr0x

This comment has been minimized.

Show comment
Hide comment
@pYr0x

pYr0x Mar 24, 2015

Is this issue releated to #762 ?

pYr0x commented Mar 24, 2015

Is this issue releated to #762 ?

alexisabril added a commit that referenced this issue Mar 24, 2015

@alexisabril

This comment has been minimized.

Show comment
Hide comment
@alexisabril

alexisabril Mar 24, 2015

Contributor

Hey @pYr0x, that issue was in regards to reading values, this one is a recent bug due to setting values.

Contributor

alexisabril commented Mar 24, 2015

Hey @pYr0x, that issue was in regards to reading values, this one is a recent bug due to setting values.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 24, 2015

Contributor

Both should be fixed in the release I'm working to get out (2.2.1)

Contributor

daffl commented Mar 24, 2015

Both should be fixed in the release I'm working to get out (2.2.1)

@daffl daffl closed this in #1549 Mar 24, 2015

daffl added a commit that referenced this issue Mar 24, 2015

Merge pull request #1549 from bitovi/1548-list-set
Fill array when setting out of bounds elements. Fixes #1548.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment