New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steal specific handling has been removed in 2.2.2 dists #1577

Closed
alexisabril opened this Issue Apr 1, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@alexisabril
Contributor

alexisabril commented Apr 1, 2015

Affects older users of steal; new steal users should not be affected as they use the system adapter(I believe).

There are steal specific conditions wrapped in steal-remove-* comments. Previously we copied files over to the dist repo(canjs.com), however we currently run them through steal for distribution now. As a result, necessary plumbing such as this: https://github.com/bitovi/canjs/blob/master/view/view.js#L385 is removed: https://github.com/bitovi/canjs.com/blob/master/steal/can/view/view.js#L393

Example shows that the mustache extension will never be registered with steal.

@alexisabril alexisabril added the bug label Apr 1, 2015

matthewp added a commit that referenced this issue Apr 1, 2015

Keep dev code for the Steal build
Legacy Steal needs the `steal.type` calls in order to use in development
and we had been removing them. Using the `+dev` option leaves these and
other dev warnings you want. Fixes #1577

@daffl daffl added this to the 2.2.3 milestone Apr 1, 2015

@daffl daffl closed this in #1578 Apr 1, 2015

@matthewp

This comment has been minimized.

Show comment
Hide comment
@matthewp

matthewp Apr 2, 2015

Contributor

There's one I missed.

Contributor

matthewp commented Apr 2, 2015

There's one I missed.

@matthewp matthewp reopened this Apr 2, 2015

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Apr 2, 2015

Contributor

Is this fixed via #1592?

Contributor

daffl commented Apr 2, 2015

Is this fixed via #1592?

@matthewp

This comment has been minimized.

Show comment
Hide comment
@matthewp

matthewp Apr 2, 2015

Contributor

Yep!

Contributor

matthewp commented Apr 2, 2015

Yep!

@matthewp matthewp closed this Apr 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment