Autorender denormalizes typeModule in Steal production mode #1595

Closed
matthewp opened this Issue Apr 2, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@matthewp
Contributor

matthewp commented Apr 2, 2015

Problem happens here:

If you are importing can/view/stache/stache it gets denormalized to can/view/stache to match the AMD build's file structure.

The fix will be to also check for System before performing the denormalization.

@matthewp matthewp self-assigned this Apr 2, 2015

matthewp added a commit that referenced this issue Apr 2, 2015

Autorender - Do not denormalize if using Steal
For the AMD build we had to add some denormalization in
can/view/autorender to match the different way modules are written. In
3.0 this won't be a problem as we'll have all of our builds work the
same way.

Since Steal supports window.define when bundled with the build this was
causing a false-negative. Checking for window.System fixes the issue.

Closes #1595

@daffl daffl closed this in #1597 Apr 2, 2015

@daffl daffl added this to the 2.2.3 milestone Apr 2, 2015

@daffl daffl added the bug label Apr 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment