Nested can.Component causes detached DOM nodes #1625

Closed
akagomez opened this Issue Apr 16, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@akagomez
Contributor

akagomez commented Apr 16, 2015

In this demo (http://jsfiddle.net/akagomez/ajdj2nu2/), when show is toggled between true/false, this markup is added/removed from the DOM:

<parent-component>
  <child-component>
    <ul>
      <li>...</li> // 1000x
    </ul>
  </child-component>
</parent-component>

Which creates this memory leak:

component-leak

Notice how the number of detached DOM nodes is double that of the length of the rendered list.

@akagomez akagomez changed the title from Nested can.Component memory leak to Nested can.Component causes detached DOM nodes Apr 16, 2015

daffl added a commit that referenced this issue Apr 20, 2015

daffl added a commit that referenced this issue Apr 20, 2015

daffl added a commit that referenced this issue Apr 20, 2015

@daffl daffl closed this in #1631 Apr 21, 2015

@daffl daffl added this to the 2.2.5 milestone Apr 21, 2015

daffl added a commit that referenced this issue May 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment