New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch/case might not work when nested #1857

Closed
matthewp opened this Issue Aug 20, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@matthewp
Contributor

matthewp commented Aug 20, 2015

@daffl ran into a bug when putting together the guide.

@matthewp matthewp self-assigned this Aug 20, 2015

matthewp added a commit that referenced this issue Sep 3, 2015

Switch helper: get expression data in switch
This fixes #1857. The bug was that if the expression passed into switch
changed the switch helepr would not re-evaluate and instead on the
switches would re-evaluate. So you could never go from one case to the
default. This fixes it by setting up the binding to the expression
within the switch helper function, so that if the expression changes it
will reevaluate the entire switch.

@daffl daffl added this to the 2.3.0 milestone Sep 4, 2015

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Sep 11, 2015

Contributor

This has also been fixed in minor. The actual problem was that the default section didn't get re-evaluated.

Contributor

daffl commented Sep 11, 2015

This has also been fixed in minor. The actual problem was that the default section didn't get re-evaluated.

@daffl daffl closed this Sep 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment