New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View bound to method breaks on re-evaluation #1891

Closed
akagomez opened this Issue Sep 8, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@akagomez
Contributor

akagomez commented Sep 8, 2015

I couldn't easily find the wording to describe this issue - I think I lack the vocabulary. Fortunately the demo makes it pretty clear.

Actual:

Num: 2
Num (x2): function () { return this.attr('num') * 2; }

Not working in latest: http://jsbin.com/zisuxiboga/edit?html,js,output

Expected:

Num: 2
Num (x2): 4

Working in 2.2.1: http://jsbin.com/kisapixeve/edit?html,js,output

@daffl daffl added this to the 2.2.8 milestone Sep 8, 2015

@akagomez

This comment has been minimized.

Show comment
Hide comment
@akagomez

akagomez Sep 8, 2015

Contributor

From what I can tell, the newVal starts referring to the compute's method here: https://github.com/bitovi/canjs/blob/master/view/scope/compute_data.js#L102

Contributor

akagomez commented Sep 8, 2015

From what I can tell, the newVal starts referring to the compute's method here: https://github.com/bitovi/canjs/blob/master/view/scope/compute_data.js#L102

@akagomez

This comment has been minimized.

Show comment
Hide comment
@akagomez

akagomez Sep 8, 2015

Contributor

A bit more context...

It appears the issue was introduced here: 23de670

While addressing an almost identical issue here: #1617

Contributor

akagomez commented Sep 8, 2015

A bit more context...

It appears the issue was introduced here: 23de670

While addressing an almost identical issue here: #1617

justinbmeyer added a commit that referenced this issue Sep 9, 2015

justinbmeyer added a commit that referenced this issue Sep 10, 2015

Merge pull request #1901 from bitovi/call-methods-1891
fixes #1891 by making executeAnonFuncs default to true
@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Sep 10, 2015

Contributor

Chris said he can port the fix to 2.2.8

Contributor

justinbmeyer commented Sep 10, 2015

Chris said he can port the fix to 2.2.8

@akagomez akagomez closed this in 74b87f9 Sep 10, 2015

akagomez added a commit that referenced this issue Sep 10, 2015

akagomez added a commit that referenced this issue Sep 10, 2015

daffl added a commit that referenced this issue Sep 11, 2015

Merge pull request #1903 from bitovi/call-methods-1891-backport
fixes #1891 by making executeAnonFuncs default to true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment