New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.jquery.dev.js doesn't include dev parts of code #2004

Closed
scaryzet opened this Issue Oct 20, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@scaryzet

scaryzet commented Oct 20, 2015

can.jquery.dev.js doesn't actually include dev parts of code. I also tried to build canjs manually but got the same result.

I wanted the class naming (via eval) chunk of code in can.Construct.extend. Had to insert it by hand into my can.jquery.js. Why it is even stripped out in non-dev builds? I know eval is evil and stuff... But console.log is much less convenient without proper class names.

Well, I can live with this, but people will think "class naming feature doesn't work, a bug?.."

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Oct 20, 2015

Contributor

There are run times that don't support eval. We want to support those runtimes.

Sent from my iPhone

On Oct 20, 2015, at 6:57 AM, Ivan Zhidkov notifications@github.com wrote:

can.jquery.dev.js doesn't actually include dev parts of code. I also tried to build canjs manually but got the same result.

I wanted the class naming (via eval) chunk of code in can.Construct.extend. Had to insert it by hand into my can.jquery.js. Why it is even stripped out in non-dev builds? I know eval is evil and stuff... But console.log is much less convenient without proper class names.

Well, I can live with this, but people will think "class naming feature doesn't work, a bug?.."


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Oct 20, 2015

There are run times that don't support eval. We want to support those runtimes.

Sent from my iPhone

On Oct 20, 2015, at 6:57 AM, Ivan Zhidkov notifications@github.com wrote:

can.jquery.dev.js doesn't actually include dev parts of code. I also tried to build canjs manually but got the same result.

I wanted the class naming (via eval) chunk of code in can.Construct.extend. Had to insert it by hand into my can.jquery.js. Why it is even stripped out in non-dev builds? I know eval is evil and stuff... But console.log is much less convenient without proper class names.

Well, I can live with this, but people will think "class naming feature doesn't work, a bug?.."


Reply to this email directly or view it on GitHub.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Oct 29, 2015

Contributor

But if can.jquery.dev.js doesn't include dev parts, that is a bug.

Contributor

justinbmeyer commented Oct 29, 2015

But if can.jquery.dev.js doesn't include dev parts, that is a bug.

@justinbmeyer justinbmeyer added the bug label Oct 29, 2015

@justinbmeyer justinbmeyer added this to the 2.3.2 milestone Oct 29, 2015

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Oct 29, 2015

Contributor

For some reason, steal-tools must be removing:

//!steal-remove-start

This should be a configurable option in steal-tools with removeDevelopmentCode: http://stealjs.com/docs/steal-tools.transform.options.html

Perhaps the build config isn't setting it right:

https://github.com/bitovi/canjs/blob/master/build/config_stealPluginify.js#L189

looks like it is. Somewhere this is breaking down.

Contributor

justinbmeyer commented Oct 29, 2015

For some reason, steal-tools must be removing:

//!steal-remove-start

This should be a configurable option in steal-tools with removeDevelopmentCode: http://stealjs.com/docs/steal-tools.transform.options.html

Perhaps the build config isn't setting it right:

https://github.com/bitovi/canjs/blob/master/build/config_stealPluginify.js#L189

looks like it is. Somewhere this is breaking down.

@matthewp

This comment has been minimized.

Show comment
Hide comment
@matthewp

matthewp Oct 29, 2015

Contributor

I did a git log search in steal-tools and I don't see there ever being a keepDevelopmentCode option, transform has always had removeDevelopmentCode. I would think changing it to removeDevelopmentCode: false would work.

Contributor

matthewp commented Oct 29, 2015

I did a git log search in steal-tools and I don't see there ever being a keepDevelopmentCode option, transform has always had removeDevelopmentCode. I would think changing it to removeDevelopmentCode: false would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment