New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort plugin: comparator set on init does not keep list sorted #2006

Closed
alexisabril opened this Issue Oct 20, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@alexisabril
Contributor

alexisabril commented Oct 20, 2015

http://jsbin.com/wugefa/edit?html,js,console

Sort plugin works in 2.3.0-pre.1, but fails in 2.3.0-beta.6

@alexisabril alexisabril added the bug label Oct 20, 2015

@alexisabril alexisabril added this to the 2.3.0 milestone Oct 20, 2015

alexisabril pushed a commit that referenced this issue Oct 20, 2015

@alexisabril

This comment has been minimized.

Show comment
Hide comment
@alexisabril

alexisabril Oct 20, 2015

Contributor

This is due to the removal of delete this._init on: 8b333ab#diff-532d6324975f398d1901af12e9086953L110

Note: this._init has also been renamed to this._initializing.

Re-adding that line fixes this issue, however breaks https://github.com/bitovi/canjs/blob/minor/list/sort/sort_test.js#L451

Contributor

alexisabril commented Oct 20, 2015

This is due to the removal of delete this._init on: 8b333ab#diff-532d6324975f398d1901af12e9086953L110

Note: this._init has also been renamed to this._initializing.

Re-adding that line fixes this issue, however breaks https://github.com/bitovi/canjs/blob/minor/list/sort/sort_test.js#L451

alexisabril pushed a commit that referenced this issue Oct 21, 2015

Alexis Abril

@daffl daffl closed this Oct 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment