Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
can.view.txt does not handle binding hookup on self-closing elements correctly #2113
This issue surfaces when a hookup ends up inside a
If you have a live-binding expression inside a
HTML5 compliant browsers will coerce this to a self-closing col element and will push the
The solution is to retain some special knowledge of self-closing tags and update the hookup to emit the correct self-closing HTML that way.
Your own documentation seems to disagree with that. http://canjs.com/docs/can.ejs.html clearly states that EJS "will still be maintained up to 3.0 and potentially after." That implies bugfixes will still be made.
Deprecation means you stop further development (of new features) and recommend people to switch over to a future-proof alternative, pending removal of the old system. It doesn't mean a free pass to ignore bugs that leave the old system in a broken state in lieu of the newest most shiny toy in the toybox.
That's right, ejs is still supported, this isn't a "won't fix".
However bugs only get fixed if someone has time and energy to fix them. This is true of all features, new and old. Pull requests fixing this bug will of course be accepted.
It's also possible to sponsor a bug to ensure it gets fixed if you can't do it yourself, @justinbmeyer can speak more about how that can work in this case.
If you're willing to accept pull requests for bug fixes, I'll look into setting one up as I've I've managed to patch this issue locally already. (Wasn't that hard once I figured out where to look.)
Is it still a hassle to check out CanJS and all its dependencies via Git on Windows? I tried this once before in the v1.1 - v2.0 timeframe and it was really annoying having to deal with subrepositories back then.
referenced this issue
Dec 3, 2015
While the removal of subrepositories greatly simplfied things, you're indirectly using several native modules as dependencies. Those were an absolute pain in the rear to build (node-gyp and Windows is hell) but I eventually managed to skirt that minefield. Oh well. ^_^