New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'pop' of undefined #2121

Closed
whitecolor opened this Issue Dec 5, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@whitecolor
Contributor

whitecolor commented Dec 5, 2015

2.3.3, 2.3.4
Uncaught TypeError: Cannot read property 'pop' of undefined .../node_modules/can/compute/get_value_and_bind.js 160 TypeError: Cannot read property 'pop' of undefined

I don't understand what is the case, but it allways worked, and it doesn't now.

    ObservedInfo.batchEnd = function(batchNum){
        while( curDepth <= maxDepth ) {
            var cur = updateOrder[curDepth].pop(); //  here is the error
            if(cur) {
                cur.updateCompute(batchNum);
            } else {
                curDepth++;
            }
        }
        updateOrder = [];
        curDepth = Infinity;
        maxDepth = 0;
    };

if add check, there will be no error:

var cur = updateOrder[curDepth] && updateOrder[curDepth].pop();

Last releases are full different of erros.

2.3.5 has already another errors...

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 5, 2015

Contributor

Is this present in 2.3.5?

Contributor

justinbmeyer commented Dec 5, 2015

Is this present in 2.3.5?

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 5, 2015

Contributor

What code causes this? I need a breaking test case.

Sent from my iPhone

On Dec 5, 2015, at 5:10 PM, Alex notifications@github.com wrote:

2.3.4
Uncaught TypeError: Cannot read property 'pop' of undefined .../node_modules/can/compute/get_value_and_bind.js 160 TypeError: Cannot read property 'pop' of undefined

Last releases are full different of erros.


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Dec 5, 2015

What code causes this? I need a breaking test case.

Sent from my iPhone

On Dec 5, 2015, at 5:10 PM, Alex notifications@github.com wrote:

2.3.4
Uncaught TypeError: Cannot read property 'pop' of undefined .../node_modules/can/compute/get_value_and_bind.js 160 TypeError: Cannot read property 'pop' of undefined

Last releases are full different of erros.


Reply to this email directly or view it on GitHub.

@whitecolor

This comment has been minimized.

Show comment
Hide comment
@whitecolor

whitecolor Dec 6, 2015

Contributor

Well for now I'm not able to reproduce it on simple example, because it broke large app and have to figure out what part of it and what events cause this (it was always working fine in erlier versions).

In 2.3.5 I can not event test it because these issues:
#2122

Contributor

whitecolor commented Dec 6, 2015

Well for now I'm not able to reproduce it on simple example, because it broke large app and have to figure out what part of it and what events cause this (it was always working fine in erlier versions).

In 2.3.5 I can not event test it because these issues:
#2122

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 6, 2015

Contributor

Yes, the latest releases contain a big rewrite to fix compute and batching bugs. However, we will keep getting out releases quickly until everything is stabilized. Thanks for reporting.

Sent from my iPhone

On Dec 5, 2015, at 5:10 PM, Alex notifications@github.com wrote:

2.3.4
Uncaught TypeError: Cannot read property 'pop' of undefined .../node_modules/can/compute/get_value_and_bind.js 160 TypeError: Cannot read property 'pop' of undefined

Last releases are full different of erros.


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Dec 6, 2015

Yes, the latest releases contain a big rewrite to fix compute and batching bugs. However, we will keep getting out releases quickly until everything is stabilized. Thanks for reporting.

Sent from my iPhone

On Dec 5, 2015, at 5:10 PM, Alex notifications@github.com wrote:

2.3.4
Uncaught TypeError: Cannot read property 'pop' of undefined .../node_modules/can/compute/get_value_and_bind.js 160 TypeError: Cannot read property 'pop' of undefined

Last releases are full different of erros.


Reply to this email directly or view it on GitHub.

@justinbmeyer justinbmeyer added the bug label Dec 6, 2015

@justinbmeyer justinbmeyer added this to the 2.3.6 milestone Dec 6, 2015

@justinbmeyer justinbmeyer self-assigned this Dec 6, 2015

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 6, 2015

Contributor

I think I know how to reproduce. Checking ...

Contributor

justinbmeyer commented Dec 6, 2015

I think I know how to reproduce. Checking ...

@whitecolor

This comment has been minimized.

Show comment
Hide comment
@whitecolor

whitecolor Dec 6, 2015

Contributor

Well a lot of events are intersecting that cause this: element custom trigged events and map's events within different components.

This fix seem to work 4bccc88

Contributor

whitecolor commented Dec 6, 2015

Well a lot of events are intersecting that cause this: element custom trigged events and map's events within different components.

This fix seem to work 4bccc88

@daffl daffl closed this in #2123 Dec 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment