New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect view model context with <content/> #2137

Closed
imjoshdean opened this Issue Dec 14, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@imjoshdean
Contributor

imjoshdean commented Dec 14, 2015

Between 2.2.9 and 2.3.0 and up, something changed with components that iterate over a list and render <content/> setting the context to be the outer template's context rather than the context within the current component.

An example of what is expected, and worked prior, can be found here: http://jsbin.com/fucokoqofu/1/edit?html,js,output

An example of what isn't expected happening as of 2.3.0 can be found here: http://jsbin.com/fucokoqofu/2/edit?html,js,output

An example of the issue still happening as of 2.3.6 can be found here: http://jsbin.com/yehupixoji/1/edit?html,js,output

A branch with a test in component_test.js is forthcoming.

@imjoshdean imjoshdean added the bug label Dec 14, 2015

imjoshdean added a commit that referenced this issue Dec 14, 2015

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Dec 14, 2015

Contributor

Related #2092

Contributor

daffl commented Dec 14, 2015

Related #2092

@daffl daffl added this to the 2.3.7 milestone Dec 14, 2015

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 14, 2015

Contributor

We should close this one and move those fiddles into the other one.

I actually wrote a test and it didn't experience this problem.

I'll checkout the bins.

Sent from my iPhone

On Dec 14, 2015, at 2:11 PM, David Luecke notifications@github.com wrote:

Related #2092


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Dec 14, 2015

We should close this one and move those fiddles into the other one.

I actually wrote a test and it didn't experience this problem.

I'll checkout the bins.

Sent from my iPhone

On Dec 14, 2015, at 2:11 PM, David Luecke notifications@github.com wrote:

Related #2092


Reply to this email directly or view it on GitHub.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Dec 15, 2015

Contributor

Closing for the other issue.

Contributor

justinbmeyer commented Dec 15, 2015

Closing for the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment