New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@index is double wrapped compute object in mustache/stache helper in latest version (V2.3.8) #2179

Closed
lihan opened this Issue Jan 11, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@lihan

lihan commented Jan 11, 2016

The @index is rendered as a number in mustache template, but is a double wrapped compute object in mustache helper, see this JSBin for illustration. http://jsbin.com/misawebeza/1/edit?html,js,output

I have traced this issue all the way back to V2.2.5, the first version that @index works correctly in mustache helper. Refer to this JSBin (http://jsbin.com/jovotareni/1/edit?html,js,output) If you change the canJS version to 2.2.6, you will see the broken result.

The same issue exists in both Mustache and Stache template.

Is there a suggested fix?

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jan 11, 2016

Contributor

A breaking example in stache in 2.3.8: http://jsbin.com/patiho/edit?html,js,output

Contributor

justinbmeyer commented Jan 11, 2016

A breaking example in stache in 2.3.8: http://jsbin.com/patiho/edit?html,js,output

@justinbmeyer justinbmeyer added the bug label Jan 11, 2016

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jan 11, 2016

Contributor

A workaround would be to make your helper check if it's still a compute and keep calling the compute. We will look to have a fix soon. Thanks for reporting.

Contributor

justinbmeyer commented Jan 11, 2016

A workaround would be to make your helper check if it's still a compute and keep calling the compute. We will look to have a fix soon. Thanks for reporting.

@justinbmeyer justinbmeyer added this to the 2.3.9 milestone Jan 11, 2016

@daffl daffl modified the milestones: 2.3.10, 2.3.9, 2.3.11 Jan 11, 2016

@daffl daffl modified the milestones: 2.3.12, 2.3.11 Jan 21, 2016

@reno1979

This comment has been minimized.

Show comment
Hide comment
@reno1979

reno1979 Jan 26, 2016

Ok same here, thank you for the milestone fix :)

reno1979 commented Jan 26, 2016

Ok same here, thank you for the milestone fix :)

@daffl daffl modified the milestones: 2.3.13, 2.3.12 Jan 29, 2016

@justinbmeyer justinbmeyer self-assigned this Feb 3, 2016

justinbmeyer added a commit that referenced this issue Feb 4, 2016

@daffl daffl closed this in #2235 Feb 5, 2016

BigAB added a commit that referenced this issue Mar 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment